JJ Marr

How do I create a custom theorem matching the existing theme?

1

I want to create an environment called "goal" and have it be formatted the same way as a theorem. I'm unsure of how to do this in an efficient way.

Documentation is not compiled

1

I really appreciate your work. This is an amazing package from a design perspective. One suggestion I have is to provide a PDF version of the documentation. I would like...

Add clang-tidy support and fix modernize-use-nullptr

5

clang-tidy is a tool that lints C++ code for common issues.[1] This would be beneficial for improving the code quality of The-Powder-Toy. This PR makes it easy to lint TPT's...

This PR is a follow-up from #966 and adds all of the clang-tidy `performance-*` checks that currently pass on The-Powder-Toy's codebase, as well as fixes/enables `performance-unnecessary-value-param`. `performance-unnecessary-value-param` prevents unnecessary copying...

Enable clang-tidy and refactor NULL to nullptr

23

clang-tidy is a linter tool that automatically checks for common code quality issues. This PR adds a cmake option `DCLANG_TIDY` that when set with `DCLANG_TIDY=ON` will automatically lint Wesnoth's code...

If a function parameter is only ever used in a `const` manner (so only `const` member functions are called or it is `const`), it can be treated as a `const...

Fix improper uses of std::move detected with clang-tidy

5

There are a few improper uses of `std::move` in the codebase. ### bugprone-use-after-move An object should never be used after it is `std::move`d from. `std::move` generally makes no guarantees about...

clang-tidy should leave code review comments

3

Instead of making people dig through CI logs, `clang-tidy` should tell the creator of the PR what is wrong and possibly suggest improvements.