Denis Isaev
Denis Isaev
``` ~/go/src/github.com/golangci/golangci-lint (feature/update-gocritic)$ fgrep go-critic go.mod github.com/go-critic/go-critic v0.0.0-20181204210945-c3db6069acc5 ~/go/src/github.com/golangci/golangci-lint (feature/update-gocritic)$ golangci-lint run test/testdata/cgo/main.go test/testdata/cgo/main.go:11:8: dupImport: package is imported 2 times under different aliases on lines 11 and 14 (gocritic) import...
Now we write: ```go db := ctx.GetGorm(). Select("max("+PointDBSchema.TripPointID.String()+") as max_id, "+ "count("+PointDBSchema.PlaceID.String()+") as rating"). Where(PointDBSchema.LocationID.String()+" = ?", locationID). Group(PointDBSchema.PlaceID.String()). Order("rating DESC"). Limit(limit) ```
Breaking change for v2. We can require not only specific linter (`staticcheck`), but also a specific check inside it.
Got a few issues that "diff" isn't installed, especially on windows. We can inline it's code into golangci-lint
In projects like Istio even repeated packages loading takes ~10s. E.g. 8s for Istio. It's important with incremental analysis when 2s we load issues from the cache and 8s load...
Like [golangci.com](https://golangci.com) has worked. How annotations look now:  They look similar to comments, but they don't appear in the comments list and on main page of a pull request.
We have too much of documentation. We need a searching to simplify things. I'm waiting for access to algolia docsearch to introduce it.