jinyus

Results 8 comments of jinyus

tiktok made some changes, this method no longer works.

I submitted a pull request #41 with this feature. You can use my fork in the meantime, in case it's not merged soon. ``` shimmer: git: url: https://github.com/jinyus/flutter_shimmer ```

Sounds like you're closing the ReceivePort on dispose(as you should). but you should create a new ReceivePort when reopening the "module" because once you call close on a stream, you...

The regression happened after upgrading from 1.34.0-beta1 -> 1.35.0 https://github.com/jinyus/related_post_gen/pull/429#issuecomment-1811459004 | Input Size | 1.34.0-beta1 | 1.35.0 | % Change | |------------|---------------|--------------|----------------| | 5k posts | 25.75 ms | 32.371...

I was looking through the code while creating the PR and realized that there is nothing wrong with the docs because the services are treated as singletons when scoped; so...

re: memory leak I mean that factory singletons are never disposed in a scope because you cannot supply a dispose method when registering them. My PR fixes this. eg: ```dart...

Here is the code for addSingletonService: https://github.com/MelbourneDeveloper/ioc_container/blob/313e32d294a9a19b2edf77e7e61d001c574ffb51/lib/ioc_container.dart#L153-L158 It doesn't allow you to supply a dispose method. So my code above would result in a memleak. Unless I'm mistaken.

Yes, but currently there is no way to supply a dispose method for `Singletons`, only transients allow it. eg: ```dart ///Add a singleton service to the container. void addSingletonService(T service)...