Jin Xing comments

Results 9 comments of


                                            Jin Xing

[CALCITE-3100] cast(? as DATE) won't work with PreparedStatement

hmm.. I think this CALCITE-3100 is really a good catch for the shortage when using `SqlDynamicParam` in `CAST`. The core problem is that `SqlValidator` infers the "type" of `SqlDynamicParam` by...

[CALCITE-3100] cast(? as DATE) won't work with PreparedStatement

@yuqi1129 THX again for this fix. It will be great if you can give a short description for the main idea of this PR as your first comment. Below comment...

[CALCITE-3455] Redundant rule firing for both logical and physical nodes

I have a question related to CALCITE-3455 but not necessarily related to this PR: How about providing an approach for RelOptRule and allow to specify that rels matched should have...

[CALCITE-771] Use materialization for scan-project-sort query

Hi @DonnyZone Would you please resolve the conflicts ?

[CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima

In current code of `SqlOperatorBinding#isOperandNull`, the doc for param of allowCast is like below ``` * @param allowCast whether to regard CAST(constant) as a constant ``` Shall we update it...

[CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima

Thanks for your fix @DonnyZone and it's good for me overall ~ I left minor comments and you can check if they are valid.

[CALCITE-3352] ProjectToWindowRule sets wrong collation on generated Window

If I remove the change of `ProjectToWindowRule`, I can pass the collation check https://github.com/apache/calcite/pull/1460/files#diff-2b9a6c719e7c1c69c76dccbbc1654ae8R6157 but fail the collation check for https://github.com/apache/calcite/pull/1460/files#diff-2b9a6c719e7c1c69c76dccbbc1654ae8R6155 That's to say the collation of `LogicalWindow` is incorrect....

[CALCITE-3438] Validator should disallow use of the GROUPING function inside a FILTER clause

Grouping function is a special agg function. +1 to find it in `AggFinder`. Rather than switching the config of `boolean grouping` in validator, do we consider to add another interface...

[CALCITE-3662] Generate wrong SQL when plan contains Project(Sort(Aggregate)) and aggregate field has no alias

How about add a test in `RelToSqlConverterTest` ?