jingshenghang

Results 4 comments of


                                            jingshenghang

[trainer] fix: DataProto concat bug when timing generate_sequences is sightly different

Replace `round()` with `math.isclose(val_a, val_b, rel_tol=0.5)` in commit 566ca6ce724684726ffaa4f0a6617ddc3cede79e

[trainer] fix: DataProto concat bug when timing generate_sequences is sightly different

@quancs @ji-huazhong Hi, I have re-committed and modified author information. Please help review, thanks.

[trainer] fix: DataProto concat bug when timing generate_sequences is sightly different

@quancs @ji-huazhong Hi, The CI failure doesn't seem to have been introduced in this PR. Could you help review and re-trigger the CI?

[trainer] fix: DataProto concat bug when timing generate_sequences is sightly different

Hi @FightingZhen @ji-huazhong @quancs , All CI has passed, please help review and merge, thanks.