Jinfeng Ni

Results 5 comments of Jinfeng Ni

@jcmcote I'll review your new patch if it's ready. Can you please submit the new patch as a new PR (or maybe I miss some part of conversation and just...

@jcmcote , (copy from my comment in DRILL-4573) I re-visited your first patch. Looks like that the change you made would cause incorrect result when the input string is a...

@jcmcote , I opened DRILL-4688 to track this incorrect regression. Please use DRILL-4688 to submit either a patch or pull request to address this issue. As part of the verification...

@jcmcote , just wanna to check the current status of your latest fix. FYI, you may consider using couple of existing methods [1] [2], when you decode the byte arrays...

I feel it might be better to work on this issue after Drill rebases Calcite. I debugged a bit in SqlValidator, and seem that the code in Drill's forked Calcite...