Jin Cao

Results 14 comments of Jin Cao

hello, I am checking internally to see who's the owner for this repo. I'm pretty sure that the original owner left the company, and I have no context here unfortunately.

hey thanks for the suggestions. instead of adding two new scrolling modes, how about if i add a new preferredScrollingDirection that mirrors the delta change? e.g. if the change is...

yes each column scrolls individually. can you clarify on what you mean by "whole number scrolling together based on change"?

hey sorry for the late followup, I totally forgot about this. in your example, each digit will simply scroll to the target number directly, e.g. 1 -> 2, 2 ->...

Great suggestion, and would love to see a PR for it if you want to take a stab! Otherwise it'll be on my back burner once I get more free...

it depends on when you do this, debug and check what's your `linearLayout.getWidth()`. my theory is that you are calling this before the linearlayout gets measured.

This unfortunately is a breaking API change to `CommonConfetti`. Can you overload the methods instead?

there's nothing unique about the explosion animation. can you try seeing if confetti shows up at all without using a custom bitmap?

Can you elaborate on what proguard rules you would need? The library doesn't use any external dependency and reflection so proguard shouldn't be unnecessarily stripping out essential code.