Jin comments

Results 174 comments of

Jin

Some classes and android resources are missing in the APK when android_binary depends on targets fetched with rules_jvm_external.

Those classes indeed aren't in the final APK, because the `wire-runtime` itself is just a compile dep for the API, and doesn't have the impl classes: ``` $ jar tf...

Some classes and android resources are missing in the APK when android_binary depends on targets fetched with rules_jvm_external.

This sounds more to do with the android rules (i.e. what aar_import propagates upwards, and what it's consumed) Maybe @ahumesky knows?

Implement the new artifacts hashing algorithm

Also please update the PR description with more details on why this is happening.

Feature Request: constraints support

Thanks, this is a very reasonable idea, and I like that it builds on top of existing mechanisms. Happy to take PRs for this. Related: https://github.com/bazelbuild/bazel-worker-api/issues/7