Jim Schubert
Jim Schubert
Thanks for this. I have some questions/comments, and tests listed below. I'm curious, how is moving COPY to the top of the file supposed to decrease build times? Are you...
@kenjones-cisco The exclude I mentioned is conditional based on previous COPY instructions. The ignore file prevents these from being sent to the build context, which won't work.
I had commented that the Dockerfile in this file is built on every commit. That doesn't seem to be the case (I thought it was previously as a tracking master...
The GEN_DIR and its contents are remapped in run-in-docker.sh. I guess because it also maps the Maven directory to the local file system, the container provides no additional benefit. Seems...
Those errors should occur on IDEs in Windows as well. A partial is like an interface which defaults to no implementation, so I'd expect the same errors you'd have for...
@iamkarlson Sorry my comment on your previous PR wasn't clear. Do you think it would make more sense to have ``` public void Trace(string message) { TraceHandler(message); } partial void...
Sounds good. I'll review again later, then. Sorry again for any confusion my comments on your other PR may have caused.
I don't see any issues (looks the same as the previous closed PR).
@faryu Thanks, now that you say the issue that is correctly what I remembered. I couldn't remember the details, just that there is a wonky difference between the two. Ideally,...
Looks like code related to my questions was changed in one of the last couple of commits in this PR to address my concerns. Looks good to me.