Jimmy Callin

Results 21 comments of Jimmy Callin

Thank you for providing me with this! It does seem to mostly work, yes :) Unfortunately it doesn't seem to work when you change properties in the `videoJsOptions` object that...

Hi again! Yes, I agree that updating using the player instance gives the best user experience, but I also think that the user expects the player to reinitialize if they...

Hi! I believe this implementation won’t work with React 18 Strict Mode, since useEffects run twice in that context. My implementation takes this in consideration. But please let me know...

@heath-freenome I think/hope I addressed all your comments now!

> So changing `any` to `WidgetProps` broke things? (Weirdly enough I couldn't respond directly to that comment) Yes, exactly. Getting the following error: ``` semantic error TS2769: No overload matches...

@heath-freenome thanks for the comments, I reverted those changes to reduce risk of missing use cases.

@masterful That would be great! Perhaps a first step could be to migrate it to this new repo? :)