Jim Isaacs
Jim Isaacs
needing to completely duplicate this logic: https://github.com/tngan/samlify/blob/2e1a93671f4b98980472d4857e08a2f99a236acd/src/binding-post.ts#L93-L123 is seriously making me reconsider using this package. @Gonyoda do you have your changes ready?
@Gonyoda I don't see a PR so I may fork and apply them.
Yep, on it, thanks for the the help and the context @Gonyoda
I've made some major changes described here: https://github.com/tngan/samlify/issues/411
@meabed I've forked and made a lot of changes myself. Considering pulling a lot of these there https://github.com/tngan/samlify/pull/412 https://github.com/tngan/samlify/issues/411
@AnthonyMDev thank you, if possible, could there be a shared open design when this happens?
You know I see `schemaName` used as the namespace elsewhere, so yeah, maybe it just needs to be used on the fragment types as well.
I don't think it would bother me 🤔. I would just suggest if that it already ends with `Fragment` do not append it again.
I'm also good with Option 2a, but just not suffixing if it already ends with Fragment. (no DogFragmentFragment).
I also do not understand your expectation. The cache policy means to fetch from the server, so doesn't it make sense that it does that when the connection is reestablished?...