samlify icon indicating copy to clipboard operation
samlify copied to clipboard

Published 20 hours ago • verified publisher icon tngan

Feat: Fix, Upgrade and Enhancements

Open meabed opened this issue 4 years ago • 5 comments

Thank you <3! the literary is incredible! I have been trying to bundle the library in typescript project and its always throwing an error of implicit type any - because of publishing .ts files in the build, So i have forked it and have done various chores, please have a look if this is something you would want to be merged. Thanks!!!

  • Upgraded packages to latest versions
  • Installer and ran Prettier
  • Fix build with typescript
  • Fixed types in build and published a fork 'samilify-js'

meabed avatar Jul 16 '20 00:07 meabed

Coverage Status

Coverage increased (+0.3%) to 85.859% when pulling 6f6700cd68570b219b7a7b0166b93e9d8c8c24cf on meabed:upgrade into 469c6befa7c6df19ff8a447bbdb87e6b55da2cb0 on tngan:master.

coveralls avatar Jul 16 '20 00:07 coveralls

@meabed Thank you so much for the contribution. We will take this PR as a reference when we start v3 development later on. I would prefer keeping samlify-js as a forked version now, and resolve the any type in this library later on.

I will mention samlify-js in the next release note as well. ❤️

tngan avatar Jul 23 '20 05:07 tngan

You are awesome :) make people text sense, thanks 🙏 let me know how can I help if needed.

meabed avatar Jul 23 '20 13:07 meabed

@meabed I've forked and made a lot of changes myself. Considering pulling a lot of these there https://github.com/tngan/samlify/pull/412 https://github.com/tngan/samlify/issues/411

jimisaacs avatar Mar 01 '21 00:03 jimisaacs

Awesome, do I need to update my pr? Or how could I help in this?

meabed avatar Mar 01 '21 18:03 meabed