Jim Idle

Results 94 comments of Jim Idle

As part of another project, I implemented the JWZ threading algorithm. There is a test tool there that will load any number of .eml files in a directory set, parse...

Did anyone look in to this more? If not, then I may do this myself. Go should be about the fastest target, assuming that it has implemented the various algorithms...

> Thanks, @kaby76 for tracking this down! yeah, I was under impression Go target was kinda screwed up. > > Does anybody know Go well enough to fix this hash...

> The problem is [here](https://github.com/antlr/antlr4/blob/8b0cc382067fcb7e011215b8e231535a09c041e2/runtime/Go/antlr/dfa.go#L121) and it goes to how DFAState objects are kept in a hash table. > > Let's compare the CSharp and Go target code side by...

One question here is whether the Go runtime is supposed to allow invocations from multiple go routines at the same time? In its current form, without too much inspection, it...

Right Ter. I have a fix. However, it is literally designed to fix this before I look to a revamp. I’m not convinced it needs a complete restart yet. This...

> Hi @jimidle !! Yep, fork then cut new branch for a PR from dev branch (not master). Maybe we start by using @kaby76 awesome fix. > > Yep, multiple...

> here @kaby76 - So, in your collection implementation, are you not using the Equals() in atn_config_set.go? The reason I ask is that, my hack just adds a bucket in...

> here @kaby76 - both my local hack and your hack seem to fix the collisions, but neither seem to fix the performance problems. The provided sample repo at the...

> > So, in your collection implementation, are you not using the Equals() in atn_config_set.go? > > @jimidle [I think I just call the DFAState equals comparison](https://github.com/kaby76/gohack/blob/c76f8d0210704a6d3af0259005fcda96b903c97a/hashtable.go#L82), which is [defined...