Jim Hester

Results 413 comments of Jim Hester

There are a number of different potential issues, https://github.com/hadley/r-pkgs/issues/483 documents some of them. Again I tried running your package (https://github.com/hechth/recetox-xMSannotator/commit/3820ca38ef890e7b0da0b10dc413e0924b174c66) tests and check locally and ran into failures with both....

Yes, your fix looks correct, would you be interested in submitting a pull request to fix this?

You will need to provide an example package that demonstrates the problem, but likely installing the package prior to running covr will fix the issue.

You should try compiling your package with `-O0` outside of using covr and see if you also get failures. Sometimes code will work when optimized but fail without optimization. When...

The accepted answer in the linked issue tells you how to do it, you set `CXXFLAGS+=-O0` in your personal makevars. `usethis::edit_r_makevars()` will open it for you if needed.

not in a properly configured system, something is wrong with your system configuration.

Sorry for the delay in reviewing this, I think what you did looks good, thanks! Can you please add a bullet to NEWS? It should briefly [describe the change](https://style.tidyverse.org/news.html) and...

`covr::package_coverage(quiet = FALSE, clean = FALSE)` Then navigate to the `opt/revr/tmp/Rtmp2JkK9z/R_LIBSd8ea44458771/perfExits/perfExits-tests` (it will be something different based on the R sessions temp directory) and look at the `*.fail` files there.

You did not miss anything, this is an area that really needs some refactoring in covr. The print method does both printing and grouping and the grouping should really be...

This is a similar issue to https://github.com/jimhester/covr/issues/241