Jim Hester

Results 413 comments of Jim Hester

I can reproduce the behavior you describe, but I don't really have time to look into if there is a obvious way to fix it. I would suggest not using...

Yeah the particular test has a conditional on the XML version https://github.com/r-lib/xml2/blob/9b5426e5cc9ae1d4eed0ec72f92f38c2cd350916/tests/testthat/test-url.R#L21 Are you seeing the conditional not working properly for some reason?

Sure, I think this makes sense, though it might be slightly tricky to implement.

Agreed, basically we need to summarize part of https://xml2.r-lib.org/articles/modification.html#removing-nodes here I guess...

I think a useful TDD task would be to take @nuest's guide and turning parts of it into a vignette / pkgdown article.

I can confirm the issue, but do not have a good solution. The issue seems to be the added nodes do not have the default namespace attached. I tried using...

Yes, very easily with [highlite](https://github.com/jimhester/highlite) ![screenshot 2018-01-23 09 40 57](https://user-images.githubusercontent.com/205275/35281706-962ce3d0-0021-11e8-92e5-978d557780ff.png) Of course highlite is not on CRAN, but it shouldn't be too hard to get on there, assuming it compiles...

No plans, but libarchive does support encrypted files (https://github.com/libarchive/libarchive/issues/579) so it is possible to add.