Jan Pieter Waagmeester

Results 90 comments of Jan Pieter Waagmeester
trafficstars

@it4workflow I tested with this example page: http://jieter.github.io/Leaflet-semicircle/examples/semicircle.html, which still looks good to me, but I released the latest version in a bit of a hurry, so I might have...

I suspected something like that, but we could try to do better on rendering in those cases... Reopened. If someone has time to make a fix, please open a PR.

How many times does the layer have at zoom level 1? Do they cover the extent of the image you are trying to save?

@janbols no idea, I have not used it touched this codebase in a while...

There can be a multitude of differences between providers, for example CORS headers and response times.

That would mean a second class, someting like `SemicircleMarker`, analogous to [`L.CircleMarker`](https://github.com/Leaflet/Leaflet/blob/master/src/layer/vector/CircleMarker.js). You are welcome to open a PR.

That line of code is from jieter/leaflet-clonelayer, it should be fixed there.

@giorgim yes I know how to fix this. The question is, should leaflet-clonelayer support plugins like this? [in this line, leaflet-clonelayer is required](https://github.com/jieter/Leaflet.layerscontrol-minimap/blob/gh-pages/index.js#L8), I think you are looking at the...

Yes, but it would be better if others can use it too. If I show you how to fix it, can you try to open a PR to contribute it...

I understand the importance of attribution, but I think adding attribution in the leaflet attribution control is not required. It can also be attributed in another part of the page...