Jinhyuk Lee

Sequence length in dnc/dnc.py

2

While implementing bAbI task based on your code, I've found that the sequence length is defined as a single integer for each batch in dnc.py. For copy task, you fed...

Suggest using Conda for faiss installation. Maybe we need to remove faiss from requirements.txt. Docker image works fine.

Error occurs if nltk.download('punkt') was not called. Maybe edit README.md or download.sh ?

https://github.com/uwnlp/piqa/blob/3a3404d82bf61a07241035eaf64be10233e266dd/squad/baseline/processor.py#L215-L237 Collate fn uses self._elmo to check the use of elmo, but the cached Processor's _elmo is set to False. (Cache was saved when processing SA+Elmo) Error log is as...

Performance difference between evaluate.py vs piqa_evaluate.py

2

Performances of two evaluation scripts differ as follows: ``` $ python evaluate.py $SQUAD_DEV_PATH /tmp/piqa/pred.json {"exact_match": 52.81929990539262, "f1": 63.28879733489547} $ python piqa_evaluate.py $SQUAD_DEV_PATH /tmp/piqa/context_emb/ /tmp/piqa/question_emb/ {"exact_match": 52.28949858088931, "f1": 62.72236634535493} ``` Difference...