Joshua Humphries
Joshua Humphries
IIUC, we are now using Snyk, so we can close this. @akshayjshah, correct me if I am mistaken and I will re-open.
Correction: we _are_ using Fossa (not Snyk), but we decided that we don't need the badges.
FYI, there is already a discussion for this: #421. There hasn't been many updates in that discussion thread in a while, but it is a thing that some of us...
@sudorandom created a repro case for this bug here: https://github.com/sudorandom/dotnet-grpc-compress-bug
> This is probably Go-specific (I don't know about other languages). This doesn't apply in most other languages, which use an "opaque" API for setting fields via setter methods instead...
> maybe it would be least surprising to also ignore in it in protovalidate It's not that it's ignored by serialization but that it gets quietly transformed into an empty...
> The state of the original concrete message is opaque to protovalidate @rodaine, this isn't *entirely* true: https://go.dev/play/p/OeTPMpkWgz_p > the following passes (and passes through protovalidate cleanly): The `IsValid()` method...
BTW, I just filed https://github.com/golang/protobuf/issues/1634
@ejona86, thanks for the transparency about the decision making. IIUC, you're saying that you expect the spec to be amended to instead use INTERNAL for this case instead of UNIMPLEMENTED....
I agree that there are deficiencies in the spec around this: https://github.com/grpc/grpc/issues/36767