Joshua Humphries
Joshua Humphries
Ah, you are right. The objective behind the suggested simplification would be to minimize the API surface area, eliding anything that isn't strictly necessary. If, for example, this could be...
> In the implementation of grpc, a goAway is sent to notify the client, but this mechanism has not been found in connectrpc. That's because connectrpc does not implement HTTP/2:...
@aimuz, in that example snippet, are you saying that `http2.ConfigureServer` with a separate `*http2.Server` is _required_ to get shutdown behave in the desired way? As for the bug, I assume...
For those curious, here's a patch I am currently using to work-around this issue. However, this patch almost certainly does not work as expected/desired with entity values. This patch is...
We are definitely batting around the best way to expose lower-level protocol details and implementation code. We were thinking of creating a separate `connect-protocol-go` repo that `connect-go` could import, and...
There are two improvements we could make here: 1. The documentation could be improved that the `Close` method of a server stream (and `CloseResponse` method of a bidi stream) are...
> Can it be implemented by creating a new context with cancel inside rpc method call and cancel it on stream.Close? Yes.
It is the same either way. But in the connect lib side: 1. Care must be taken to ensure that the cancel function is _always_ called at the end of...
> But if I use this one and mix with grpc imports than I get issue. This is a known issue with Protobuf Go -- you can only use a...
@gcemaj, I think we need to considerably revise those Go docs. The thread-safety of `StreamingHandlerConn` is a little more complicated than those docs imply. It is in fact safe to...