Joshua Humphries

Results 433 comments of Joshua Humphries

These three of the new conformance tests in the main protobuf repo fail with Go's protojson implementation: https://github.com/protocolbuffers/protobuf-go/commit/bc1253ad37431ee26876db47cd8207cdec81993c#diff-cadbc1c67a15bd6fc4334382feaa7a783f938482f783b9cb017c949ad26877a2R1-R3 I suspect updating protojson so these test cases pass will be enough...

I think it's probably fair to close this issue now that #1216 has been resolved. While it's not automatic to create extension types as part of `NewFiles`, it is now...

@EwanValentine, can you provide details about the source file you are trying to use? A small repro case for example?

@donkeywon, @EwanValentine, I am not able to reproduce this issue. Can you provide information about your source files? A small repro case maybe?

@printfn, some details on the files you are using, like a repro case, would be incredibly helpful for us to reproduce and fix. Could you give examples on why the...

@donkeywon, it turns out that this is a problem in your proto code, and it just happened to be overlooked by earlier versions of `grpcurl`. That's because the earlier versions...

@printfn, well, the issue is the way the gRPC Go runtime returns descriptors in this case, from its reflection implementation. Instead of just returning a "not found" error for the...

> However, the placeholder it is sending is invalid since it contains the literal string `""` as the value of the descriptor's [syntax field](https://github.com/protocolbuffers/protobuf/blob/v24.4/src/google/protobuf/descriptor.proto#L91) (this could arguably be considered a...

> @jhump seems reasonable to support go 17, 18, 19 to me. Sure, seems fine to me. I had commented almost a year ago, before 1.18 was released.

@mvillafuertem, @banandh, I am no longer with FullStory, so I don't usually have time to work on patches for this sort of thing. Sorry! I still watch the repo and...