grpcui icon indicating copy to clipboard operation
grpcui copied to clipboard

Published 20 hours ago • verified publisher icon fullstorydev

use go:embed to bind data

Open xwjdsh opened this issue 3 years ago • 2 comments

Simplify code.

xwjdsh avatar Jan 23 '22 15:01 xwjdsh

@xwjdsh, thanks for the patch!

We intentionally support Go runtimes older than G 1.17. After 1.18 is GA (which should be in the coming month), maybe we can re-assess since, IIUC, the Go team will drop support for 1.16 at that point (based on their release policy).

In the meantime, let's leave this pull request open and consider merging it after that.

jhump avatar Feb 14 '22 15:02 jhump

@jhump actually the embed feature added in go1.16, I can change the version of the go.mod to go.1.16 if you want.

xwjdsh avatar Feb 14 '22 16:02 xwjdsh

This would need a rebase for conflict

dragonsinth avatar Dec 21 '22 19:12 dragonsinth

@dragonsinth Updated.

xwjdsh avatar Dec 22 '22 09:12 xwjdsh

https://github.com/fullstorydev/grpcui/pull/156/files#diff-288b5fde448529a95912cdc56f6eddfbb5baaff11e11bf53c3d1e3efed7c91b5R57

maybe // Add embedded resources bundled in standalone package TOC?

go1. 17 (released 2021-08-16) @jhump seems reasonable to support go 17, 18, 19 to me.

dragonsinth avatar Dec 22 '22 13:12 dragonsinth

@jhump seems reasonable to support go 17, 18, 19 to me.

Sure, seems fine to me. I had commented almost a year ago, before 1.18 was released.

jhump avatar Jan 03 '23 15:01 jhump