vision3d icon indicating copy to clipboard operation
vision3d copied to clipboard

Should grid point randomly sampled or evenly distributed

Open turboxin opened this issue 4 years ago • 1 comments

Hi @jhultman,thanks for sharing your implementation.

According to the original paper, the grid points are uniformly sampled within a proposal, I think "uniformly" here means evenly distributed in every dimension( from figure4 we can see the red grid points are not randomly sampled), and the name "grid" itself may also claim this point.

I think "uniformly" here is different from "uniform distribution" given by torch.rand

https://github.com/jhultman/vision3d/blob/0789508438f15fe0537c06713d4afc67b9abe4a3/pvrcnn/detector/roi_grid_pool.py#L59

turboxin avatar Apr 09 '20 12:04 turboxin

Hi @turboxin, yes I think you are right -- I will fix this. Thanks!

jhultman avatar Apr 09 '20 22:04 jhultman