Josh Huckabee

Results 8 comments of Josh Huckabee

@piranna, while we appreciate the pull request, its not inline with the current style of the code. The code follows the generally accepted standard of "brackets everywhere". e.g. ``` javascript...

I like the thinking behind this. Two questions for you @a-wallen... 1. What do you envision as the return type of the two methods listed in your requirements? Is that...

@hirowatari This appears to be fixed in the latest version of the gem. Try the same thing on 2.0.4.

I can also report that I'm seeing the same behavior and I am not accessing the bitmap object outside of the `dispose` method. I'm creating an image in an Angular...

I have narrowed this down to [`CGImageRelease`](https://github.com/mkloubert/nativescript-bitmap-factory/blob/master/plugin/BitmapFactory.ios.js#L62) calls. Removing those seems to fix the problem, but I don't fully understand the memory management implications there. Here is the [crash file](https://gist.github.com/jhuckabee/a486310df73e063e882ddc445be06ab7)...

Unfortunately that didn't work for me. According to the [docs](https://developer.apple.com/reference/coregraphics/1556742-cgimagerelease), this shouldn't fail if `CGImageRef` is NULL. I wonder if this is an issue with [iOS runtime marshaling](https://docs.nativescript.org/runtimes/ios/marshalling/Marshalling-Overview.html) in NativeScript?

From what I'm reading, `UIImage` is an autoreleased object. Is calling `CGImageRelease` even necessary here? What it sounds like is happening is by the time the autorelease process runs, we've...

What version are you using? I haven't upgraded yet, but looks like it was addressed in e8055020381dcf973ebc54706735ab214384f76f.