Jonathan Hedstrom
Jonathan Hedstrom
Coming back to this after a while, I'm not exactly sure what the best path forward here is. Having too many grunt to composer command mappings seems a bit unmaintainable,...
This came up again in the `copy:defaults` task (which copies files back from the build into `src/sites/defaults`), and the workaround was again to set `mode: false` on that command.
Tests are failing due to https://github.com/ariya/phantomjs/issues/11637. Other drivers it seem will happily click on the first link with a matching title (eg, the 'my account' link is on the page...
This probably needs some tests. Also, it may require changes to `grunt-phpcs` since even passing empty files, that module is still specifying the standard, etc: ``` Executing: vendor/bin/phpcs --report=full --standard=vendor/drupal/coder/coder_sniffer/Drupal,vendor/drupal/coder/coder_sniffer/DrupalPractice...
Need to add 2 warnings here: 1. If phpcs paths/dirs are specified in `Gruntconfig.js` *and* there is a `phpcs.xml` file, need to warn that the grunt configs will be ignored....
@grayside I've added the first warning, but cannot remember how the second warning actually differs.
Hmm, this still needs a bit of work I think. The standard in the phpcs file isn't actually being used as the code in `quality.js` is still specifying the standard.
#241 was merged. Thanks all!
Makes sense!