jhance

Results 36 comments of jhance

Okay, we agree that this default makes more sense. But I think the name `conly` does not make sense if it defaults to `True`. Instead, lets rename to `enable_cxx` and...

I don't agree with your diagnosis of `cffi` silently breaking due to kwargs. Its passing the kwargs to something that doesn't accept the `conly` parameter as far as I can...

Well, the "just want to focus on python3" bit is solved now. `bzl` is not necessary but it is useful if you want to use our python generator. The import...

We have an internal "example repository" that we use to validate that the open source equivalent of our build rules will continue to work. I got approvement from legal team...

Pants doesn't support a hermetically source built python so I'm not sure I would say it supports it natively. Its support is more similar to bazel upstream than these rules...

I think it would make more sense for this list to go in cfg.py, or disable this feature altogether in the open source version of our build tools

Actually, I think it makes sense to remove this list entirely, and add a flag to piplib `preserve_docstrings` that defaults `False`.

Our mypy rules don't seem like they actually function here, and its not caught in our internal smoketest since it doesn't include any references to `dbx_mypy_test`. I'm not sure what...

`# type: ignore[mypy:misc, other_checker:foo]` seems like a better syntax and actually compatible with the parser. In the case of mypy we would simply recognize `mypy:x` as the same as `x`...

Given that there is not a standardized behavior for these in the PEP I don't think we should be restricted by what choices Pyright makes. It would be a simple...