Jhey Tompkins

Results 36 comments of Jhey Tompkins

Giving this one a bump as it's been 7+ days โœŠ I would love to make a contribution into the project ๐Ÿš€

@ghengeveld @shilman โ€“ Found a moment to revisit this ๐Ÿ‘ What approach do we think would be best here? I was thinking of having some kind of `global` state that...

> @jh3y Looks like some CI things are failing after i merged in the base branch. Do you recon you could have a look to see if you could fix...

Hey @kai-oswald ๐Ÿ‘‹ This is great! Thanks for contributing ๐Ÿ‘ That's fine. We can come up with a good solution first and then drop it into the react app using...

Fixed dimensions ๐Ÿ‘ But we are no longer spinning ๐Ÿ˜ญ I think this is due to how `requestAnimationFrame` has been used. I'll leave a comment on the code ๐Ÿ‘ And...

Yep ๐Ÿ‘ I see it working again now ๐Ÿ˜… The changes for `requestAnimationFrame` would still be needed though as we don't get the benefit of `requestAnimationFrame` this way. I think...

Hey @kai-oswald ๐Ÿ‘‹ Yeah, I see the stutter too ๐Ÿ˜ญ Could be an expensive operation. However, I have seen another approach that also had a kinda stuttery result. This [article](http://usefulangle.com/post/45/animate-favicon-gif-javascript)...

Hey @RamanaVem ๐Ÿ‘‹ There is an open PR for it #38. However, I'm not sure if it's something we will pull in or not as the performance trade-off might not...

Hey Kent ๐Ÿ‘‹ Let's have a think of what we can do then. I've made an attempt on some changes that I've tested out. > For one, it won't work...

Also, can we add `hacktoberfest-accepted` label to this PR? ๐Ÿ™ ๐Ÿ‘€