John Gresty

Results 8 comments of John Gresty

`PINENTRY_USER_DATA` is used by gpg-agent to pass data to the underlying pinentry process, however `USE_CURSES` is unique to macos as pinentry normally uses the `DISPLAY` variable on other platforms. https://github.com/GPGTools/pinentry/blob/b7195e9d4c098ea315e18ade3b4dab210492fadf/macosx/main.m#L67

> Successor to this PR is available at #112715 and has suggestions from code review applied, thank you @r-xyz Thanks for picking this up, sorry I did not follow up....

Is this patch waiting for upstream changes? Is there any other work that needs doing to support private repos other than what is outlined in this PR?

Oddly the expression evaluates perfectly fine in a nix repl, I wish nix-instantiate would give useful errors...

Oh and alerting, how will we know if this fails?

I've started a branch to upgrade it: feat/update-kin-openapi That branch changes all the references so it compiles, however we are panicking at runtime when resolving references: ``` panic: reflect: reflect.Value.Set...

The version of ejs used as a hard dependency (3.1.10) is not impacted, only the version pulled in as a transitive dependency of ejs-lint. Generally we don't consider dev dependencies...

So from upstream the typing is correct as [reference objects](https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.3.md#reference-object) also use type string for their referenced strings. In this case I think the discriminator mapping object needs to be...