Jay Gowdy

> Related failures: https://ci.nodejs.org/job/node-test-commit-arm/41957/nodes=rhel8-arm64/console https://ci.nodejs.org/job/node-test-commit-arm/41957/nodes=ubuntu1804-arm64/console https://ci.nodejs.org/job/node-test-commit-arm-debug/2195/nodes=ubuntu1804-arm64/console > > ``` > 02:30:42 ccache gcc-8 -o /home/iojs/build/workspace/node-test-commit-arm-debug/out/Release/obj.target/openssl/deps/openssl/openssl/ssl/ssl_ciph.o ../deps/openssl/openssl/ssl/ssl_ciph.c '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_HAS_QUIC' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DOPENSSL_NO_HW' '-DOPENSSL_API_COMPAT=0x10100001L' '-DSTATIC_LEGACY' '-DNDEBUG' '-DOPENSSL_USE_NODELETE' '-DOPENSSL_BUILDING_OPENSSL' '-DECP_NISTZ256_ASM'...

It seems there's a failure with the Windows compile, but I'm not sure how that would be related to this PR. The Linux build with the `-msign-return-address=all` does appear to...

All checks passed after re-running post rebase.

I would recommend we use one or more 3 byte characters and one or more 4 byte characters to ensure no artificial shortcuts are taken. https://design215.com/toolbox/utf8-3byte-characters.php http://www.i18nguy.com/unicode/supplementary-test.html

This seems like a really good idea. 👍

> I thought about that but, due to security, I did not want accidental selection. One mitigation for this concern might be that the user will have to git add...

> if they're reviewing what they're commiting hopefully. For security, I'd rather not fall on the side of assumptions. True, true. > Since there is no harm in supporting it,...

🤦‍♂️ I should have looked first.

I believe the existing --max-depth command should materialize / checkout the Nth commit and scan that checkout *plus* the 49 newer deltas, rather than only scanning the 50 newest deltas.

> `tartufo pre-commit` (or any other tartufo command for that matter) shouldn't be affected by user configuration otherwise it means behavior is non reproductible and can be influenced, without knowing,...