jgostick

Results 116 comments of jgostick

I thought I had replied to this when you posted it, but see that I did not, sorry for ignoring this. Thanks for this suggestion. I have not acted on...

It is sooo strange. This used to work, and I don't understand what could possibly have changed. I have to think that we changed something in OpenPNM, but I do...

Wow, that would be phenomenally helpful. Do you need help with the git fork / pull request process? As for implementation, there are only a few things to think about:...

You can see an example [here](https://github.com/PMEAL/porespy/blob/dev/porespy/simulations/_dns.py)

Thanks for the detailed bug report and solution. Much appreciated. Would you be willing to do a pull request? Those changes are pretty minor so it should be a quick...

Got pseudo_gravity_packing working well, the clearance and mode args now work. And adding new spheres to existing structures works... ![Figure_1](https://github.com/PMEAL/porespy/assets/5092049/1021c54a-0283-4769-ab00-6682a2b87379)

Now that we have declared the `dev` branch to be "version 3" I think we can merge this PR.

Thanks for reporting this. It's a new function so was bound to have a few rough edges.

I think this was coming from openpnm which was used to do the finite difference calculations in the backend. I have pushed a fix for this and it's on pypi....

This is actually a good idea...like a physically meaningful tolerance rather than an abstract mathematical one. Given this wrapper is meant to be helpful, this seems a step in that...