porespy icon indicating copy to clipboard operation
porespy copied to clipboard

Fixing pseudo packing functions

Open jgostick opened this issue 11 months ago • 1 comments

Fixes #916 Fixes #757 Fixes #649 Fixes #647 Fixes #575

jgostick avatar Mar 10 '24 19:03 jgostick

Got pseudo_gravity_packing working well, the clearance and mode args now work. And adding new spheres to existing structures works...

Figure_1

jgostick avatar Mar 10 '24 19:03 jgostick

Codecov Report

Merging #922 (d3417c0) into dev (f053893) will decrease coverage by 0.2%. Report is 22 commits behind head on dev. The diff coverage is 84.1%.

Additional details and impacted files
@@           Coverage Diff           @@
##             dev    #922     +/-   ##
=======================================
- Coverage   83.1%   83.0%   -0.2%     
=======================================
  Files         36      36             
  Lines       4577    4662     +85     
=======================================
+ Hits        3807    3872     +65     
- Misses       770     790     +20     

codecov[bot] avatar Mar 12 '24 02:03 codecov[bot]

Now that we have declared the dev branch to be "version 3" I think we can merge this PR.

jgostick avatar Mar 25 '24 15:03 jgostick