Jefferson González
Jefferson González
Ok, will implement your suggestions later and borrow more from your primary_selection code for the incremental yielding timeout + err checking (I thought about the process_write + yielding reuse but...
The other set of suggestions handled on this commit https://github.com/lite-xl/lite-xl-lsp/commit/27c241da98a3b28509329a4e68a2a8dc4cffe3d5 except for the raw processing chunk chop out.
More suggested corrections https://github.com/lite-xl/lite-xl-lsp/commit/607cc85978b6fe169c2e6cabe779776d752267f8
Tested and found that `$savestatus` is not getting replaced to the intended value
I would suggest providing a ready to use `color_to_32` function as on your example, preferably implemented on the C side maybe as part of `renderer`.
> Do we need that? Normally one should avoid doing image generation in Lua anyways, and should either load from a file that contains raw pixel data, or use a...
> Just curious: are there any performance regressions with us switching to SDL_Renderer? On linux the cpu usage seems around the same on my system with amd apu, but... just...
On a windows bare metal install when also performing rapid wheel scrolling up and down: | Rendering Method | CPU USAGE (%) | GPU USAGE (%) | | :-------------------- |...
> Pretty huge regression. Can we somehow keep using SDL_Surface and have correct scaling? Reverted the change and disabled a second HIDPI window check on Windows since it is not...
> I think it's because emojis are intended to be square. A way to fix this is to match all fonts' baseline together when drawing, but I don't know how....