Jonathan Ginsburg

Results 57 comments of Jonathan Ginsburg

I think this should be a general cleanup across the whole Org's repos. Ofc, this should trigger new major releases for all the maintained repos. WDYT? I have proposed this...

I agree with @devoto13 in that the way it is configured now, we cannot conduct pre-merge testing in SauceLabs and BrowserStack. However, I propose a workaround for that in https://github.com/karma-runner/karma/issues/3786....

> Do you refer to the npm run commitlint -- --from `git merge-base origin/master $GITHUB_SHA` command from the test.yml? This was never intended to run on Windows or used by...

@davidje13 also please take a look at the checks as there are some failures :)

> > @davidje13 also please take a look at the checks as there are some failures :) > > seems Node 10 doesn't have `matchAll`. Easy to replace. I'll update...

> > seems Node 10 doesn't have matchAll. Easy to replace. I'll update it when I get time. > > I would be more comfortable landing this change in a...

Thanks so much for taking a look @johnjbarton. Enjoy your retirement! @devoto13: Do you want me to take a look at this?

Hello @ptmono can you please provide repro steps? Please beware that I am not familiar with emacs, so help me a bit with being overly detailed with your repro steps...

Shouldn't there also be a change in `package.json`? Otherwise, how did you generate this PR?