James Gentes

icon company @procore icon location Bend, OR icon location Dev Productivity @ Procore, Former Eng Mgmt @ Cloudflare, Co-founder @Tend.ai, @Symantec, @VERITAS. Virtual computing patent https://bit.ly/3nlAWYC

Results 51 comments of James Gentes

Handle keys with dash better

+1

Default tag_name and release_name to be `github.ref`

I followed the readme, ended up with 'Release refs/heads/master' :(

Default tag_name and release_name to be `github.ref`

`github.sha` doesn't work due to this error: `pre_receive Sorry, branch or tag names consisting of 40 hex characters are not allowed.`

Cant add the tags automatically if its valid without entering key button like enter/tab etc

You can use th inputValue & onChangeInput to take care of this: ``` this.handleTags(filters)} onChangeInput={filter => this.handleChangeInput(filter)} inputProps={{placeholder: 'Add a filter'}} /> ``` Then you have: ``` handleTags(filters) { this.setState({filters});...

Cant add the tags automatically if its valid without entering key button like enter/tab etc

You could validate the tag in handleChangeInput.. Once it is a valid email, you push it into state.tags and clear state.tag.

Cant add the tags automatically if its valid without entering key button like enter/tab etc

Then your regex isn't very good :) Your regex should prevent abc@co because that's not a valid email address. On Mon, Mar 4, 2019 at 9:17 PM Abhay Bhosale wrote:...

Vite/Rollup/ESBuild cannot process the dynamic imports in `EuiIcon`

+1 for having a simpler solution, but nice to have a workaround. I'm using Vite.

wrangler dev fetch service from localhost

@grahamlyons I'd be curious to know if Miniflare will suit your needs for this. https://miniflare.dev/

wrangler dev fetch service from localhost

Stay tuned :wink:

`wrangler dev` in 11.0 is non-functional when there are deployed workers with non-specific routes

@danbars do you see this while using Miniflare?