John Caruso

Results 19 comments of John Caruso

> As a note, SvtVp9EncApp only supports yuv input Oh good to know! > ffmpeg -i bbb-2m-4k-30fps.mp4 -an -c:v libsvt_vp9 -g 30 -minrate 6000k -maxrate 17400k -b:v 12000k -f null...

I also ran it again after running `sudo sysctl -w kernel.sched_rt_runtime_us=1000000` and I got this error ``` munmap_chunk(): invalid pointer Aborted (core dumped) ``` Just wondering if there is anything...

> Looking good, it's only missing the domain part, you can access it with `const { setDomain } = useDispatch( ONBOARD_STORE );` (see `client/landing/stepper/declarative-flow/internals/steps-repository/choose-a-domain/index.tsx`) I've added the clearing of the...

I believe I've found the crash data `podcasts/EpisodeDetailViewController.swift:118: Fatal error: Unexpectedly found nil while unwrapping an Optional value` ``` Crashed: com.apple.main-thread 0 libswiftCore.dylib 0x3a8c8 closure #1 in closure #1 in...

I’ve been looking at this issue, and I have a couple of ideas how I could address it but curious what “should” be done: 1. if the episode is missing,...

I haven't been able to reproduce it yet. I did notice the `ListeningHistoryViewController+Table.swift` crash logs as well, but that one made even less sense to me because in order to...

Thanks for that follow up! I was only able to artificially reproduce the error by preventing podcast json from being saved to the DB when Discover is loaded (which probably...

I've tried to reproduce the issue with the assumption that it is a "cleanup" process that is deleting the podcast using the steps from https://github.com/Automattic/pocket-casts-ios/pull/137 however I am still unable...

Thanks @emilylaguna ! That does seem to reproduce it but in a slightly different way. Debugging through that it seems to never be able to download the podcast episode, maybe...

Ok, I think this is ready for review again! Both test plans (the main one in the description and Emily's steps) work without crashing. If an episode can't be found,...