Jonathan Gagné

Results 14 comments of Jonathan Gagné

## Review checklist for @jgagneastro ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...

A reminder for myself: (1) Should add link to tutorials in README directly (2) should replace the path "../datasets/CrA-9_2019_IFS_pca_annulus.fits" with os.path.dirname(__file__)+"/datasets/CrA-9_2019_IFS_pca_annulus.fits" such that the tutorial works regardless of where we...

Hey Valentin, sorry for the delay. I got back from vacation last week, but I was slow to get into the dozens of things I have gotten myself into before...

Regarding "State of the field: Do the authors describe how this software compares to other commonly-used packages?", I think it would be relevant to discuss similarities/differences with Adam Burgasser's splat...

Regarding "References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper [citation...

Valentin, I am a bit worried about the use of Allers et al. (2007) Na I index with a spectral resolution much lower than SpeX-prism. Was this tested for a...

> The answer is yes: the main routines of `special` are in fact compatible with the input spectrum of any kind of object regardless of the way the spectrum was...

> Thanks for the suggestion, I have now updated the paper draft including a comparison to `splat`. I am a bit reluctant to add it on the readthedocs documentation though,...

> You're right this is risky (I do not know either whether these were tested at low spectral resolution). At the moment, a warning is raised when the routines calculating...

I have one issue when trying to follow the example analysis with special. It seems like my pip install did not download the special-extras directory. Is this intended ? EDIT:...