Jonah Gabry comments

Results 726 comments of


                                            Jonah Gabry

Bump codecov/codecov-action from 4 to 5

Even though the test-coverage workflow passes there's an error: > Error: Error: No coverage reports found. Please make sure you're generating reports successfully. > ==> Failed to run upload-coverage Not...

Add cmdstanr to GHA workflows

I think the only reason I hadn't done this before is to avoid any headaches due to compilation issues that occasionally happen on GHA. Since so few tests required cmdstanr...

Assorted ggplot syntax changes

Thanks. The `size` -> `linewidth` is one I've tried to fix already but I probably missed a few. If you find cases that I've missed we can change those now...

Feature request: ppc_rootogram_grouped()

Glad you like the new rootogram style and thanks for the suggestion. @behramulukir Any interest in working on this when you have time?

Feature request: ppc_rootogram_grouped()

Thanks @behramulukir! Hope your semester is going well.

Updating residual plots

Yeah I think we should make new functions for these residual plots. We can merge #349 with @tjmahr's changes to `ppc_error_scatter_avg` and then create separate functions like @avehtari described in...

fix ppc-distribution docs for argument usage & correct test function in test-ppc-distribution

Great, thanks for finding these issues.

use posterior::gpdfit and posterior::qgeneralized_pareto()

Good point. Yeah you can just replace the bodies of the functions with calls to the posterior versions.

use posterior::gpdfit and posterior::qgeneralized_pareto()

> At least in github only I and Juho Timonen have used loo::gpdfit, so I guess it can be removed OK in that case, we can try removing it and...

use posterior::gpdfit and posterior::qgeneralized_pareto()

The error now is because apparently these functions aren't exported from posterior, they're just internal functions. That would be easy to change but it would require doing a CRAN release...