Jonah Gabry
Jonah Gabry
@avehtari I think you said in the Stan meeting today that you had made some new comments on this, but I don't see additional comments. Or did I misunderstand what...
I think it looks pretty good. A few thoughts/questions: - Do we think it would be more confusing for the user to have different functions for scores and metrics, or...
Good point about computing several with just one call. And yeah, we'll definitely need good documentation and good informative error messages to help the users figure out which arguments they...
Thanks. I'm trying to remember if there was some reason we suggested `roxygen2::roxygenize()`. Does using `devtools::document()` work fine for you with Stan based packages?
Ok great, thanks for the replies. Sounds good to me.
@tjmahr sorry for the delay in reviewing this. Been a busy few days. Will try to get to it soon!
@tjmahr Also see @avehtari's comment here https://github.com/stan-dev/bayesplot/issues/350#issuecomment-2902272870, which supports @kruschke's suggestion. When we were always using the mean it didn't matter if we were computing `y - stat(y_rep)` or `stat(y...
Yeah I have mixed feelings about this. Both feel intuitive to me but represent slightly different things. A couple of options (there are probably others): 1. Change `ppc_error_scatter_avg` to do...
Oh and posterior also needs to be added to the DESCRIPTION file
I think for testing monitor we should pass it a fixed set of posterior draws instead of creating a stanfit object (it can handle both). That's because with different hardware...