jcommon

jcommon copied to clipboard

Changes from clean code first part

3

Dear David, I was studying the book [Clean Code](https://www.goodreads.com/book/show/3735293-clean-code) and it has a section where the class SerialDate in Jcommon library is refactored. It is horrible to follow a refactoring...

adamtnagy

both methods starts with declaring width and height as follows int height = ins.top + ins.bottom; int width = ins.left + ins.right; and adding the insets again in the return...

tillwoitendorf

Bumps [junit](https://github.com/junit-team/junit4) from 3.8.2 to 4.13.1. Release notes Sourced from junit's releases. JUnit 4.13.1 Please refer to the release notes for details. JUnit 4.13 Please refer to the release notes...

dependabot[bot]

Refactoring based on Uncle Bob Clean Code Book

rildikondi

renamed the ArrowPanel into ArrowButton and refactored some of the classes that use it to make more sense

thomas-terry

[JDK-4312117 - Drawing with AffineTransform widens text](https://bugs.openjdk.java.net/browse/JDK-4312117) has been fixed since JDK1.5 jcommon requires 1.6 - therefore all coding related to this workaround can be removed e.g. [isUseDrawRotatedStringWorkaround](https://github.com/jfree/jcommon/blob/master/src/main/java/org/jfree/text/TextUtilities.java#L809) [setUseDrawRotatedStringWorkaround](https://github.com/jfree/jcommon/blob/master/src/main/java/org/jfree/text/TextUtilities.java#L822)

Pitterling

stringToMonthCode bug and general question

1

I found this library by reading the "Clean Code" book which has a chapter on refactoring SerialDate class. Were those changes rejected because of being backward incompatible or for some...

alexandroid