stringToMonthCode bug and general question

[alexandroid]

I found this library by reading the "Clean Code" book which has a chapter on refactoring SerialDate class.

Were those changes rejected because of being backward incompatible or for some other reason?

What about small bug fixes which the book highlighted, like in stringToMonthCode() which does not return -1 for the cases when the input is a string with a number, i.e. "12345" (it simply returns the parsed number, i.e. 12345 in this case).

[jfree]

I know some of the refactorings required (at the time) a later version of the JDK than we were supporting, but that is no longer a factor. Others should be incorporated, it just never got to the top of my priority list. I remember reading through that chapter and agreeing with 90% of the changes…I think there were one or two that I thought were wrong. I guess I could go through that chapter again and make some updates.

You don’t want to know how many of my colleagues at work have mentioned that chapter of that book to me…nor how often! :-)

Best regards, David

On 24 Sep 2015, at 17:24, alexandroid [email protected] wrote:

I found this library by reading the "Clean Code" book which has a chapter on refactoring SerialDate class.

Were those changes rejected because of being backward incompatible or for some other reason?

What about small bug fixes which the book highlighted, like in stringToMonthCode() which does not return -1 for the cases when the input is a string with a number, i.e. "12345" (it simply returns the parsed number, i.e. 12345 in this case).

— Reply to this email directly or view it on GitHub.