jfhr comments

Repositories
Issues
Comments

Results 3 comments of


                                            jfhr

Add type security for configuration files

Hi, I wanted to validate my config files so I made an [unofficial JSON schema file](https://gist.github.com/jfhr/181123d7acc87ea329be3700d9c37594). Example use: ```JSON { "$schema": "https://gist.githubusercontent.com/jfhr/181123d7acc87ea329be3700d9c37594/raw/9dafefb638f8ff0660930cc48debefa1dfcd87ca/lighthouserc.schema.json", "ci": { } } ``` Let me know...

why is the first argument to an http.Server's upgrade event listener called response?

Hey, I'll send a PR this evening.

why is the first argument to an http.Server's upgrade event listener called response?

Looks like I mixed up the two different upgrade events. In that case, this issue is obsolete. Sorry for the confusion and thanks Ipinca for clearing this up.