Joao F. Ferreira

Results 23 comments of Joao F. Ferreira

Hi @leonard84, thanks for the quick and pertinent reply. Please find below a few additional points: - I would say that your comment on increasing the cognitive load could also...

Thanks @SunBeomSo It's a valid point, but still, the problem here is that there's a call to an external function before updating the balance. I'm in favour of changing this...

Thanks for the suggestion. So far, we didn't have the need to have that information condensed in a single file. What sort of format did you have on mind? If...

Thanks, @BuggerBag @pedrocrvz WDYT ?

Thanks @gsalzer. We'll look at this in more detail. @dindonero Should the SARIF be the same in this case?

This seems to have been solved in the `bytecode` branch, right @gsalzer ?

Thanks for opening this issue, @SunBeomSo. It's a good point. We have included them as three separate contracts because we tried to be faithful to what we found in our...

Thanks, @nveloso! I would say that the contracts should still be in the dataset, since this is a dataset of _Solidity smart contracts_ and they might be compiled with versions...

I'm tagging @ruimaranhao and @pedrocrvz for their opinion on this.

I suggest the following: 1. We keep these contracts as they are 2. If possible, we add _new_ versions of these contracts where the deadcode is always used I added...