Jacob

Results 16 comments of Jacob

@jasonday Has there been any progress on this issue? I'm currently using printThis in an Ember addon and having the exact same issue as the OP. As has been noted,...

@jherdman I've got a proof-of-concept branch with a working refactor (all tests green) if you want to check it out: https://github.com/jfdnc/ember-metrics/tree/refactor/remove-ember-object One of the things that I don't feel entirely...

> ...service refactor and GA refactor. Would you be amenable to making these their own PRs? Happy to, yep! > ...Do we offer a deprecation release and THEN an upgrade...

I guess `willDestroy` could still hang around, since its common in other Ember-land constructs, and is used in Glimmer components as well.

Another minor note in thinking about deprecations moving forward, the [`options` property](https://github.com/adopted-ember-addons/ember-metrics/blob/master/addon/services/metrics.js#L38-L44) of the metrics service should also probably be phased out. Its only existing to reflect values that the...

> continue supporting script tag removal? It may make more sense to isolate the removal to just the testing environment. Given that those scripts are registering code that isn't torn...

One way to attach markers for script removal would be like ```javascript import { guidFor } from '@ember/object/internals'; ... class MyCoolAdapter extends BaseAdapter { constructor() { // could technically just...

@GreatWizard PR looking solid! I don't mind deferring my branch for PR, looks like you took a similar approach (I like the `_activeAdapter` change as well, I wasn't entirely sure...

@maxymczech Your link got double-pasted in the OP here: https://github.com/maxymczech/ember-data-crash-test

Just a ping here as this PR and the [issue for it](https://github.com/ember-template-lint/ember-template-lint/issues/2028) aren't being acknowledged. This can be moved forward or not, I just want to be sure that the...