Pepe Fagoaga

Results 169 comments of Pepe Fagoaga

> Hi @jfagoagas I appreciate your reply. I get the idea to maintain a single check and adjust the level of severity according to the circumstances. Nonetheless, I think the...

> @sergargar #3967 > > Updated - acm_certificates_expiration_check, acm_certificates_expired_check Hi @MrMoshkovitz, what @sergargar meant is just to leave the `acm_certificates_expiration_check` and handle both scenarios within the check with two different...

Hi @MrMoshkovitz did you see the above message? Thanks!

> pired certificates as a (high / mediu Good point, this is a great example to add the https://docs.prowler.com/projects/prowler-open-source/en/latest/tutorials/scan-unused-services/ logic to the check, so by default not used won't be...

Hi @MrMoshkovitz we cannot remove neither change the current ACM check name since it'll be a breaking change in Prowler. As I commented in the issue, the better way is...

Hi @kagahd I like your idea but we are not sure about including it at this time since we want to create an execution manager in top of Prowler's scan....

> Hi @jfagoagas could you please advise, why the `pr-lint-test` [tests](https://github.com/prowler-cloud/prowler/actions/runs/9174232628/job/25224637564?pr=4018) are failing after my last last commits from today? When I run them locally, only 2 of a total...

> Hi @jfagoagas, the github workflow failed again with the same errors. Do you have another idea what the reason could be? In [line 155](https://github.com/prowler-cloud/prowler/actions/runs/9176744167/job/25232742488?pr=4018#step:15:196) it says `AttributeError: module 'prowler.providers.common'...

I have just one question left because I'm not sure, what was the previous behaviour when running an specific port check with the `public_ports` set to `True`? I thought we...

> > what was the previous behaviour when running an specific port check with the `public_ports` set to `True`? I thought we were not raising a finding > > Exactly,...