Pepe Fagoaga

Results 169 comments of Pepe Fagoaga

> Well as a workaround for me both options are ok however, the original CSV spat out by prowler should be structured and mustn't require any manual intervention. I don't...

@puchy22 could you please take a look at this? Thanks!

> @jfagoagas yes, i wrote a customized check on the basis of rds_instance_backup_enabled to skip replica instances. Are you planning to make a PR with that? Could be interesting to...

> @jfagoagas i committed the customized check but not sure if its worth. Its very close to rds_instance_backup_enabled and would be better to have it as an option for this....

Hi @uridealo, I've pushed a new version using the Prowler configuration file with a new `check_rds_replicas` value set to `True` by default. Please execute it agains your environment and let...

> @jfagoagas @uridealo why we have only done this for this check? It would be interesting to add this logic for the rest of RDS Instance checks. I think for...

> @jfagoagas i tested your changes. ImO the logic is weird. I only skip replicas when check_rds_replicas is NOT set in config. When leaving out "True" in rds_instance_backup_enabled.py:24 i can...

Hi @uridealo we've made the decision to set the `check_rds_instance_replicas` by default to False so you don't need to do anything and your RDS instance replicas won't be included in...

> @jfagoagas In which version will this be released? Also in v3? Hi @uridealo this will be included in the following v4.2.0 and v3.16.5. Thanks!

@puchy22 could you please take a look at this? Thanks!