Jake Zimmerman comments

Results 360 comments of


                                            Jake Zimmerman

Sorbet can't process methods with optional positional arguments BEFORE required ones

A related but different example is #9650, where Sorbet fails to report an arity error that it should have reported (vs this example: it reports an arity error that it...

Treat `T.attached_class` as fixed+invariant in `final!`

Sorry, looks like I messed some things up, and broke tests. Going to try to fix it on this flight and then re-request review.

wip: See what breaks if we treat map! as it should

We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...

rbi: Require `Array#concat` args to have same type as receiver

We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...

rbi: Require `Array#concat` args to have same type as receiver

This gets a little trickier because our `[x, *y]` desugaring depends on calling `.concat`. We'll probably need to either find another Array function that works like concat (takes rest args)...

Type parameters are not fully compatible with type members

Note that the equivalent thing with `lower` and `T.anything` is also a problem #### Input [→ View on sorbet.run](https://sorbet.run/#%23%20typed%3A%20true%0A%0A%23%20Type%20parameters%20don't%20have%20lower%2Bupper%20bounds%20like%0A%23%20type%20members%20do%2C%20which%20means%20that%20they%20don't%20behave%0A%23%20correctly%20in%20certain%20subtyping%20cases.%0A%0Aclass%20A%0A%20%20extend%20T%3A%3ASig%2C%20T%3A%3AGeneric%0A%20%20abstract!%0A%0A%20%20X%20%3D%20type_member%20%7B%20%7Blower%3A%20T.anything%7D%20%7D%0A%0A%20%20sig%20%7B%20returns%28T.anything%29%20%7D%0A%20%20def%20anything%0A%20%20%20%200%0A%20%20end%0A%0A%20%20sig%20%7B%20returns%28X%29%20%7D%0A%20%20def%20also_anything%0A%20%20%20%20anything%0A%20%20end%0A%0A%20%20sig%20%7B%0A%20%20%20%20type_parameters%28%3AU%29%0A%20%20%20%20%20%20.params%28x%3A%20T.type_parameter%28%3AU%29%29%0A%20%20%20%20%20%20.returns%28X%29%0A%20%20%20%20%7D%0A%20%20def%20another_anything%28x%29%0A%20%20%20%20x%0A%20%20end%0Aend) ```ruby # typed: true # Type parameters don't have lower+upper bounds...

[Issue-1317][Mock solution] Enable validation between methods defined via inheritance and mixins

Hey thanks for taking an interest in Sorbet! Note that #1317 is likely the sort of task that will not be able to be completed without substantial involvement from the...

Add signatures for `Net::HTTP.get*`

We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...

Add signatures for `Net::HTTP.get*`

Hey, sorry for the delay. This causes about 50 errors on Stripe's codebase, they look all good and trivially fixable with the `T.must` autocorrect. I will have to fix those...

Too much gap between body text and wide things

This also affects code blocks ```md # Usage 1. Download the `hanging-punctuation.lua` file: :::{.wide} ```{.bash} curl -sSLO https://raw.githubusercontent.com/jez/pandoc-hanging-punctuation/refs/heads/master/hanging-punctuation.lua ``` ::: 1. Download the `hanging-punctuation.css` file: :::{.wide} ```{.bash} curl -sSLO https://raw.githubusercontent.com/jez/pandoc-hanging-punctuation/refs/heads/master/hanging-punctuation.css...