Jake Zimmerman

Results 359 comments of Jake Zimmerman

Hey sorry for the long review and all the spam comments. The review took so long because our script for testing sorbet-runtime changes against Stripe's codebase had atrophied and broken....

Further context on why this has `label:hard`: For Sorbet to be aware that a variable’s type has changed, one of two things need to happen: 1. that variable has to...

**Update**: it's not enough to just say "you have to use `T.all`": even if we did that, it would not allow doing the "natural" thing of using `self.new` to instantiate...

It looks like that's a part of the CommonMark spec: > If the [info string](https://spec.commonmark.org/0.31.2/#info-string) comes after a backtick fence, it may not contain any backtick characters. (The reason for...

We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...

`module_function` is pretty poorly supported in Sorbet from the start (even statically). Technically there is precedent for something similar in sorbet-runtime which is why I've chosen to leave this open:...

A couple thoughts: - This produces a ton of warnings when building on macOS. I would like to figure out a way to get rid of those warnings before proceeding...

I tried building it locally and it fails for me: ``` ❯ bazel cquery //main:sorbet No cached Bazel v6.5.0 found, installing for darwin-arm64... /var/folders/gt/3hq5tw5d62bfpr903pnnsdh80000gn/T/tmp.gL47mPwzKg % Total % Received % Xferd...

I built again, and it seems that problem went away? I'm wondering whether it has something to do with fresh cache or not. Going to have to try to blow...

I just went and checked out a non-`master` commit, rebuilt, and it's producing arm64 binaries 🤔