Jake Zimmerman
Jake Zimmerman
> What do you think about adding the `cache.aborted` stat into the two tests that were modified? That way we could see any of the cases where the poisoning caused...
> It looks like the test failure is due to a cached file not raising the same duplicate type_member error. If you want to commit the test diff and make...
We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...
We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...
We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...
We have a policy of testing changes to Sorbet against Stripe's codebase before merging them. I've kicked off a test run for the current PR. When the build finishes, I'll...
We have resisted implementing support for `===` on type objects, because there are type objects where it doesn't make sense, for example generic types, proc types, `T.self_type`, etc. which can't...
@bandantonio The difference between the solution you propose and the one I propose is that in mine, the choice of mark is configurable. Continuing with your solution, it would be...
I have no strong opinion about either solution (one helper or two) in so far as it supports choosing what to use for the begin and end marker.
Thanks but I’m really hoping for arbitrary markers. My intention is to use markup like ```md red ``` with custom inline CSS to recreate the highlights with the same colors...