Tim Seckinger

I think this would be better as a separate matcher to avoid confusion around why assertions with strings pass and to ensure users are explicit about what type they expect...

We could add black and gray instead, but I'm a bit sad that the color vibrance that people get by default will go away. Is the output really that bad?...

> Elsewhere it was proposed that: > > ``` > await dispatch({name: 'test_fn_start', test}); > const timeout = test.timeout || getState().testTimeout; > ``` > > ...could be changed to: >...

I believe the category of "passing state into tests/hooks" suggestions is currently not a top priority unfortunately. Note that we recommend not using any `jasmine`-specific APIs like one of the...

I was thinking about something like: ```js let lastTestFailed; export const saveTestState = async (testFn) => { try { await testFn() lastTestFailed = false; } catch (err) { lastTestFailed =...

@hedgerh You deleted `e2e/snapshot-escape/__tests__/snapshot.test.js` according to the diff, that's where the error comes from ;)

Hi! I wanted to get to know the Rome codebase a bit so I thought I'd look at a formatter issue and then a lint rule, or something like that....

@MichaReiser thanks for the tips! The solution I've started yesterday is roughly the iterator solution but I didn't `impl Iterator`, just wrote a ```rs pub struct FormatNumberLiteral { fn fmt(&self,...

Since this appears to be inactive, I'm trying this one out to write my first lint rule, let's see how they are written in Rome :smile:

This PR is ready for review now! :) I left some comments with explanations and some with minor implementation questions, but overall I'm pretty happy, esp. with the diagnostic as...