jeswinkoshyninan

@oliviassss @johngmyers can you please take look into this same ?

Thank you @shraddhabang , seems like test looks good to us. Can we merge this change?

@shraddhabang @johngmyers @oliviassss tagging again incase if we lost the track of this PR, seems like the tests looks good and okay to merge ?

@oliviassss thank you for the comments Regarding your first point, I have made the changes and the second point, currently if VPCID is set, then that will be returned instead...

@oliviassss make sense, have pushed the changes, please take a look.

@oliviassss PR desc updated with the manual test details.

@oliviassss just for transparency, seems like when enabling debug logs, the logs which we set to message user "vpcid is specified" is not working when I am testing. This will...

@oliviassss identified the problem with logger and fixed. I can see the logs what we set. ``` ➜ .kube kubectl logs aws-load-balancer-controller-796b7c7f76-wrvdx -n aws-lb-controller -f {"level":"info","ts":"2024-05-14T21:41:20Z","msg":"version","GitVersion":"","GitCommit":"","BuildDate":""} {"level":"debug","ts":"2024-05-14T21:41:20Z","msg":"vpcid is specified using...

I have found that the problem is causing because the processing of default webhooks is not from the [here](https://github.com/istio/istio/blob/master/operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go#L263) instead it is [process](https://github.com/istio/istio/blob/master/operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go#L361) after those manifests/resources are getting applied/reconciled. I...

@oliviassss thank you for the updates, please let me know once we confirm the release v2.9.0.