Jesse Duffield
Jesse Duffield
yep I'm happy to include that other PR in the release
What's the rationale behind this?
@Ryooooooga just checking in again. What's the intention behind this PR?
I'm gonna close this due to inactivity but feel free to raise again if you want @Ryooooooga :)
Perhaps we should write all outputs of logged commands to the command log panel. We already do for pulling/pushing. Might make things cluttered but worth doing a spike on it...
Nice work @Ryooooooga . My main hesitation here is that if a given git version fails, it might not be obvious why, and it would be good to fix it...
https://github.com/jesseduffield/lazygit/pull/2754 is approved so I'll close this off. But thanks for laying the groundwork @Ryooooooga !
I've chucked a 'good first issue' label on this, but I would hold off the work until https://github.com/jesseduffield/lazygit/pull/2390 is merged.
Hmm here's the code we currently have in pkg/gui/controllers/helpers/working_tree_helper.go ```go if len(self.model.Files) == 0 { return self.c.ErrorMsg(self.c.Tr.NoFilesStagedTitle) } if !self.AnyStagedFiles() { return self.PromptToStageAllAndRetry(self.HandleCommitPress) } ``` I didn't realise we actually...
Looks like we can close that off in this case